taocpp / PEGTL

Parsing Expression Grammar Template Library
Boost Software License 1.0
1.94k stars 228 forks source link

`contrib/integer.hpp` should include `<numeric_limits>` #232

Closed le-migou closed 3 years ago

le-migou commented 3 years ago
#include <tao/pegtl/contrib/integer.hpp>
int main () {}

Gives

In file included from a.cpp:1:
../../../external/taocpp/pegtl/include/tao/pegtl/contrib/integer.hpp:63:60: error: ‘numeric_limits’ is not a member of ‘std’
   63 |       template< typename Integer, Integer Maximum = ( std::numeric_limits< Integer >::max )() >
le-migou commented 3 years ago

Sorry, I meant <limits> of course.

d-frey commented 3 years ago

But we do include <limits>. Can you dig deeper and figure out what is actually going on on your system?

le-migou commented 3 years ago

Sorry, my bad I was really too far behind !

ColinH commented 3 years ago

No problem, thanks for reporting, even if it turned out to be a non-issue :-)