search

taocpp / PEGTL

Parsing Expression Grammar Template Library
Boost Software License 1.0
1.94k stars 229 forks source link

add msys2 CI #366

Closed Totto16 closed 1 month ago

Totto16 commented 2 months ago

This adds a Msys2 CI.

I tested it in Msys2 Clang64 locally and fixed #365 too. For that I also had to change some code, so that Msys2 uses windows wide string functions to open a file, otherwise it wouldn't work.

Totto16 commented 2 months ago

CI failures are unrelated to this PR, macos-11 isn't available anymore as github runner, and the clang versions that fail are also not available anymore in the ubuntu runners 😓

uilianries commented 2 months ago

I'll send a new PR fixing the CI by today later.

ColinH commented 1 month ago

@uilianries Any update?

uilianries commented 1 month ago

@ColinH Sorry, totally missed it. I'm going to check it now.

uilianries commented 1 month ago

@ColinH Sorry the confusion, the PR #367 is the fix that I mentioned before. Just need a review to be merged.

ColinH commented 1 month ago

Is #367 the only PR that we need to merge now? In other words, did you incorporate the MSYS2 fixes into #367?

uilianries commented 1 month ago

Is #367 the only PR that we need to merge now? In other words, did you incorporate the MSYS2 fixes into #367?

Yes, I rebased those changes via the commit https://github.com/taocpp/PEGTL/pull/366/commits/8171fc48917a30fc259308336a0551e787b58c43

Totto16 commented 1 month ago

Thank you @uilianries for your work ❤️

Totto16 commented 1 month ago

@ColinH would it be possible to have new release, since now mysys2 is fully supported and works again?

ColinH commented 1 month ago

The main branch already has some changes towards a PEGTL 4.0 which I'm otherwise working towards on the work branch; the 4.0 with MSYS2 support will be released when it's ready.