search

taocpp / taopq

C++ client library for PostgreSQL
Boost Software License 1.0
265 stars 40 forks source link

Build Conan package on CI #15

Closed uilianries closed 5 years ago

uilianries commented 5 years ago

Hi!

This PR is proposed on #12 where I said about include Conan on CI jobs.

There is an interesting point in this recipe at line 41 where I expose all symbols when compiling on Windows, with Visual Studio and providing shared library (DLL). The point is that taopq doesn't export its symbols by __declspec so I ask to Cmake expose all symbols. It works well, but I would prefer use dll export if possible.

Is there any restriction distributing taopq as dll?

d-frey commented 5 years ago

Thanks. Both TravisCI and AppVeyor are currently showing errors, maybe because I forgot to update the version extraction in build.py. I fixed it in master now, please merge with your PR and see if it fixes the problems.

For the symbol visibility: I am not using Windows, so I don't know what is needed to generate usable DLLs. I appreciate any progress, there have also been #13 and #14 recently. Please have a look and align with those PRs (they are likely outdated now, so a new PR would be needed). For this PR, just exporting everything seems OK.

uilianries commented 5 years ago

Okay, I just merged taopq/master into my master to get synchronized. Let's wait for CI, but it's working on my environment now.

Will check both issues, thanks for sharing this.