search

taocpp / taopq

C++ client library for PostgreSQL
Boost Software License 1.0
265 stars 40 forks source link

Vs support #2

Closed bouassaba closed 7 years ago

bouassaba commented 7 years ago

Hello,

In addition to my previous pull request, here I fixed build errors on MSVC.

Best, Anass

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 96.028% when pulling 60342ae7fcbf543f1867a4ccfb346c2c5c359a93 on anass-b:vs-support into b2e9ee46ada24d7b5d683c477c6d8916d1a5ea41 on taocpp:master.

d-frey commented 7 years ago

Thank you for working on this. I'm not sure why you closed the issue, but I committed some of the changes manually (and slightly modified).

For the CMake part, I currently try to figure out the best way to go for several libraries. My time is sadly quite limited, but I hope that I have some more time for this in December. Don't hesitate to re-open the issue (or open a new one) if you still want to help with this. One thing I'd also like to set up when CMake support is available is CI testing with AppVeyor, so I can guarantee Windows support for all future versions. If your CMake approach would work with that, I'd be really happy :)