search

taocpp / taopq

C++ client library for PostgreSQL
Boost Software License 1.0
264 stars 40 forks source link

Broken Windows build on CI #48

Closed uilianries closed 3 years ago

uilianries commented 3 years ago

For documentation proposal.

Related to https://github.com/actions/virtual-environments/issues/4243

The current approach is installing PostgreSQL 13 by choco, and start the service via PowerShell.

For some reason, it fails to start. I tried to reproduce the same error, but it works for me and I don't have a second Windows machine to validate it.

Another possible approaches:

d-frey commented 3 years ago

Unfortunately, the right approach is to wait until the issue is fixed. The linked issue says there's a bug in FindPostgreSQL, but it doesn't say what the bug is and only suggests that it will be reported upstream, not mentioning whether the one who found the bug actually did so. Anyways, I think that the Windows images should have working PostgreSQL and CMake installations and the fixes should be done upstream. If you still want to try and create a workaround I certainly appreciate that, but in the long run it is up to GitHub/Microsoft to take care of that.

uilianries commented 3 years ago

Fixed by #49

We can improve it in the feature, the broken CI is fixed now.