search

taocpp / taopq

C++ client library for PostgreSQL
Boost Software License 1.0
265 stars 40 forks source link

Aggregate Support optimization #73

Closed gelijian closed 5 months ago

gelijian commented 5 months ago

how about using pfr to implement this feature

gelijian commented 5 months ago

the link of pfr project: https://github.com/boostorg/pfr

d-frey commented 5 months ago

There is no reason to add a dependency to another library (other than libpq, of course), not even if we were to copy the code for PFR into our repository. PFR is multiple headers with 5000+ lines of code to replace a single header of ours with ~150 lines of code. And I won't even start on the complexity of the implementation. So, no, that provides no benefit and I will absolutely not do that.

gelijian commented 5 months ago

Thanks for your reply. Is it possible to increase the limit of the number of struct field from 26 to some larger number like 128.

d-frey commented 5 months ago

I've raised the limit to 99 for now. Is this sufficient or do you need more?

gelijian commented 5 months ago

Yes, thanks a lot