taoensso / carmine

Redis client + message queue for Clojure
https://www.taoensso.com/carmine
Eclipse Public License 1.0
1.15k stars 131 forks source link

Allow database in URI for compatibility with other clients? #113

Closed marick closed 8 years ago

marick commented 9 years ago

It took me rather a long time of puzzling to realize that Carmine doesn't support a /<db> option for connections, as redis-rb does. (It's silently ignored.) A quick scan found only two other clients that obviously support URIs at all. Of them, Dartist (Dart) also supports /<db>. ServiceStack.Redis (C#) requires an &db=1 at the end of the URI.

If it seems useful to add handling of /<db> in carmine.connections.parse-uri, I'll make a pull request.

marick commented 9 years ago

(I do know that using multiple databases is somewhat deprecated. In our case, it's a lot easier to have development and test versions of redis by having two databases than by having two instances. And the main issue is principal of <my and people like me's> least surprise.

ptaoussanis commented 9 years ago

Hi Brian, sure - PR welcome - thanks! :-)