taoensso / carmine

Redis client + message queue for Clojure
https://www.taoensso.com/carmine
Eclipse Public License 1.0
1.16k stars 131 forks source link

in macro enqueue-request, cluster-keyslot# is always nil #118

Closed jafingerhut closed 9 years ago

jafingerhut commented 9 years ago

I was testing some Eastwood changes in the next (not yet released) version, and found that this let statement has no body, thus it always returns nil: https://github.com/ptaoussanis/carmine/blob/master/src/taoensso/carmine/commands.clj#L86-L92

I have not investigated carefully enough to know whether that is a bug, but it does look like fairly odd code.

ptaoussanis commented 9 years ago

Hi Andy, that is a bug. The particular value's currently unused, but might be in future. Appreciate these reports and your work on Eastwood!

Cheers :-)