search

taoensso / carmine

Redis client + message queue for Clojure
https://www.taoensso.com/carmine
Eclipse Public License 1.0
1.16k stars 131 forks source link

Sharded Redis #133

Closed shmish111 closed 9 years ago

shmish111 commented 9 years ago

I appreciate that this functionality would be superseded by Redis Cluster on Redis 3 but for those of us who will be using Redis < 3.0 for a while has anyone looked at implementing something like ShardedJedis? If not, would a PR be accepted if I work on it?

ptaoussanis commented 9 years ago

Hi David,

Now that Cluster's officially out with Redis 3, other sharding approaches are basically obsolete.

For Cluster support - most of the hairy internals are already in Carmine to support Cluster in a way that works well with Carmine's own features (request pipelining and parsers, etc.). There's still some work needed, and that'll definitely need to come from PR since I'm short on time lately and don't have any need for Cluster myself.

There's a cluster ns with an old (+ possibly out-of-date) sketch of the work still needed. I'd suggest starting there if you or anyone else were interested in investigating a Cluster PR.

Cheers :-)

ptaoussanis commented 9 years ago

I appreciate that this functionality would be superseded by Redis Cluster on Redis 3 but for those of us who will be using Redis < 3.0 for a while

Sorry, I somehow missed this context. Is there a specific reason you would be hesitant to switch to Redis 3? It's a non-breaking upgrade in the vast majority of cases I believe.

shmish111 commented 9 years ago

Because going from our current Jedis wrapper with sharding to carmine and redis cluster all in one go will be scary but I suppose it's probably for the best.

On Thu, May 7, 2015 at 1:19 PM, Peter Taoussanis notifications@github.com wrote:

I appreciate that this functionality would be superseded by Redis Cluster on Redis 3 but for those of us who will be using Redis < 3.0 for a while

Sorry, I somehow missed this context. Is there a specific reason you would be hesitant to switch to Redis 3? It's a non-breaking upgrade in the vast majority of cases I believe.

— Reply to this email directly or view it on GitHub https://github.com/ptaoussanis/carmine/issues/133#issuecomment-99819444.

ptaoussanis commented 9 years ago

Ahh, gotcha. Does Jedis have support for Cluster yet? Perhaps you could switch to Jedis+Cluster as a first step?

shmish111 commented 9 years ago

Nope :( Plus I do not like it or the wrapper we use (an old in-house one) so I don't want to make our code even more dependent on it.

On Thu, May 7, 2015 at 1:23 PM, Peter Taoussanis notifications@github.com wrote:

Ahh, gotcha. Does Jedis have support for Cluster yet? Perhaps you could switch to Jedis+Cluster as a first step?

— Reply to this email directly or view it on GitHub https://github.com/ptaoussanis/carmine/issues/133#issuecomment-99820176.

ptaoussanis commented 9 years ago

Closing this for now.