taoensso / carmine

Redis client + message queue for Clojure
https://www.taoensso.com/carmine
Eclipse Public License 1.0
1.15k stars 130 forks source link

Add ssl option for connection spec #203

Closed carlduevel closed 6 years ago

carlduevel commented 6 years ago

Hey Peter, I really like carmine and have used it successfully for quite a while now. Now I have to move a considerable code base to AWS and therefore also use ElastiCache. Since all traffic inside the AWS has to somehow be encrypted, I need a ssl parameter for our carmine connections. I know that this has been discussed already, but the cloud aspect was not mentioned there and so we thought I would give it another try.

Please see the pull request as a very rudimentary proposed implementation that I would further refine if you're open to the idea.

alphaone commented 6 years ago

That would be so goooood!

ptaoussanis commented 6 years ago

Hi Carl, on board to see a refined PR for this - thank you :+1:

carlduevel commented 6 years ago

It is a bit more polished now. Do you have any feedback/suggestions?

ptaoussanis commented 6 years ago

Merging manually in a moment, thanks again for this :+1: