search

taoensso / carmine

Redis client + message queue for Clojure
https://www.taoensso.com/carmine
Eclipse Public License 1.0
1.15k stars 130 forks source link

Add support for Redis 5.0 features, including Streams API #210

Closed bobby closed 5 years ago

bobby commented 5 years ago

I generated a new commands.edn in order to address #208.

New commands.edn adds commands:

and changes command:

hden commented 5 years ago

Any update on this?

tirkarthi commented 5 years ago

Thanks much for the PR @bobby . I wrote a blog post with this PR and things work well. One command I was missing was the XACK command due to which I was not able to acknowledge the messages read by different consumers in a group. I think it will be an useful addition along with XGROUP command for which you have raised an issue upstream command generation from reference.

Thanks

tirkarthi commented 5 years ago

Thanks much @bobby I have verified the usage of new commands in https://github.com/ptaoussanis/carmine/pull/210/commits/ca59a6bf172ebd2a868b1e1a5a8e7fe21f15d693 and they work fine :)

bobby commented 5 years ago

Okay, I've updated as of adding XINFO to the mix. I've tested locally on a rather complex distributed system, and it works well. @ptaoussanis when are you comfortable merging these changes, after antirez/redis-doc#963 is merged, or could we do before?

ptaoussanis commented 5 years ago

Hi Bobby, sorry for the long delay replying. This looks great, will try merge + cut a new release tomorrow 👍Cheers!

ptaoussanis commented 5 years ago

Merged and cut [com.taoensso/carmine "2.19.0"], on Clojars now 👍

tirkarthi commented 5 years ago

Thanks much :)