search

taoensso / carmine

Redis client + message queue for Clojure
https://www.taoensso.com/carmine
Eclipse Public License 1.0
1.15k stars 130 forks source link

Upgraded connection pool blocks program from exiting #213

Closed tetigi closed 5 years ago

tetigi commented 5 years ago

Hey there -

We're using Carmine 2.19.0, and it seems that the connection pools are blocking the Java process from exiting. I have created a minimal project demonstrating the problem here, along with a description of the behaviour: https://github.com/tetigi/carmine-issue

Have confirmed that the blocking happens on two different devices, on Java 8, 9 and 10. Downgrading Carmine to 2.18.2 or not creating a thread pool (:pool :none) fixes the problem.

Still trying to figure out what the exact problem with commons-pool2 is. Seems like it was introduced in this commit: https://github.com/ptaoussanis/carmine/commit/b850ebb6b610de995d0885efbc067bfc18f0bae8

ptaoussanis commented 5 years ago

Hi there, thanks for the report. Confirmed on my end.

Looks like an upstream bug from commons-pool. Since we don't actually need the newest version, will issue a hotfix shortly that reverts the version bump update.

tetigi commented 5 years ago

Thanks for the quick fix! Looks great now.