try to add ping pong test in the pub/sub listener

taoensso / carmine

Redis client + message queue for Clojure

https://www.taoensso.com/carmine

Eclipse Public License 1.0

1.15k stars 130 forks source link

try to add ping pong test in the pub/sub listener #219

Closed ylgrgyq closed 3 years ago

ylgrgyq commented 5 years ago

Hi ptaoussanis, Thank you for your work on this great lib.

Could we consider to add a ping/pong test in the pub/sub Listener? So if the remote redis crash unintentionally, the pub/sub Listener can know the connection is broken and inform the application layer instead of probably waiting on the Socket for a long time.

Ref. https://github.com/antirez/redis/issues/420

ptaoussanis commented 3 years ago

@ylgrgyq Adding something similar in next release, thanks Rui!