Adds minimal deps.edn so that the project can be used with tools deps

taoensso / carmine

Redis client + message queue for Clojure

https://www.taoensso.com/carmine

Eclipse Public License 1.0

1.15k stars 130 forks source link

Adds minimal deps.edn so that the project can be used with tools deps #260

Closed svdo closed 1 year ago

svdo commented 2 years ago

I added a minimal deps.edn file that only lists Carmine's dependencies, so that I can use Carmine from my tools.deps based project.

ptaoussanis commented 1 year ago

@svdo Hi Stefan, thanks for this! I'm not so familiar with deps.edn - could you please clarify:

It's not possible to use Carmine from a tools.deps project without Carmine providing a deps.edn file?
If so, is it really expected that every library needs to include a deps.edn file - potentially maintaining duplicate deps information in a large proportion of cases? That doesn't seem right, could there be some other solution we're possibly overlooking?

Thanks!

svdo commented 1 year ago

@ptaoussanis No a deps.edn file is normally not needed, since you have published this on clojars. I needed it in my fork because otherwise I would have had to publish my fork to clojars or something, that I didn't want to do. So now that you merged my PR I don't need my fork anymore and this PR can be discarded I believe.

ptaoussanis commented 1 year ago

Okay, thanks for clarifying! Closing then. Cheers :-)