search

taoensso / carmine

Redis client + message queue for Clojure
https://www.taoensso.com/carmine
Eclipse Public License 1.0
1.16k stars 131 forks source link

XTRIM function signature does not match documentation #280

Closed Oddsor closed 1 year ago

Oddsor commented 1 year ago

The xtrim-function signature does not match the redis command.

Function doc:

[key trim]
Trims the stream to (approximately if '~' is passed) a certain size.

XTRIM key trim

Redis command doc:

XTRIM key <MAXLEN | MINID> [= | ~] threshold [LIMIT count]
ptaoussanis commented 1 year ago

@Oddsor Hi Odd, as mentioned in your linked command doc - it looks like the extra arguments were added in Redis 6.2.0. Sometimes it can take a while for new args, etc. to find their way to the official docs - then there can be a further delay getting into Carmine.

Carmine's command spec is updated with each release, so this update will be included in the upcoming Carmine v3.3.

In the meantime, you can always use the redis-call util to execute any Redis commands with any arguments - regardless of the state of the Redis docs or Carmine's command spec.

Hope that helps? Cheers! :-)

Oddsor commented 1 year ago

Hi! Sorry, I didn't notice that the Redis command signature had changed 😊

But yes, as you mentioned I figured out that I could use redis-call as a workaround; very handy! Looking forward to the new release 🎉

ptaoussanis commented 1 year ago

No worries! 👍