search

taoensso / encore

Core utils library for Clojure/Script
https://www.taoensso.com/encore
Eclipse Public License 1.0
272 stars 53 forks source link

Missing `if-cljs` macro #46

Closed nasutiooon closed 5 years ago

nasutiooon commented 5 years ago

Getting this exception when I want to use taoensso.encore.test/use-fixures: 

Caused by: java.lang.RuntimeException: No such var: taoensso.encore.test/if-cljs

It seems because it's not being required

https://github.com/ptaoussanis/encore/blob/master/src/taoensso/encore/test.cljx#L30

(ns taoensso.encore.test
  ;; Unfortunately needs to be a separate namespace for now due
  ;; to https://github.com/ptaoussanis/encore/issues/37
  #+clj
  (:require
   [clojure.test    :as test :refer [is]]
   [taoensso.encore :as enc  :refer [have?]])

  #+cljs
  (:require
   [cljs.test       :as test :refer-macros [is]]
   [taoensso.encore :as enc  :refer-macros [have?]]))
ptaoussanis commented 5 years ago

Thanks for the report, fixed in v2.106.0. 👍

nasutiooon commented 5 years ago

Was just about to do pull request. Apologies for the slow response!

ptaoussanis commented 5 years ago

Oh, no problem at all! I just happened to need to push a new version for other reasons - so figured I'd include this quickly.