search

taoensso / encore

Core utils library for Clojure/Script
https://www.taoensso.com/encore
Eclipse Public License 1.0
274 stars 52 forks source link

Clojure 1.11 warning `abs already refers...` #60

Closed dharrigan closed 2 years ago

dharrigan commented 2 years ago

Hi,

With Clojure 1.11 nearly around the corner, testing has revealed this issue with taoensso.encore:

WARNING: abs already refers to: #'clojure.core/abs in namespace: taoensso.encore, being replaced by: #'taoensso.encore/abs

Thank you.

-=david=-

ptaoussanis commented 2 years ago

Hi David, this has already been addressed in the latest versions of Encore - please see here.

dharrigan commented 2 years ago

Ah!

Yes, totally right, but I forgot (I just digged a bit deeper there now), that I'm using tempura latest version (1.2.1) which still uses an older version of encore.

com.taoensso/tempura 1.2.1
  . com.taoensso/encore 2.94.0
    X org.clojure/tools.reader 1.2.1 :superseded
    . com.taoensso/truss 1.5.0

Could tempura be updated to pull in the latest please?

Thank you.

ptaoussanis commented 2 years ago

I always update Encore and other dependencies whenever cutting a new release of a library, but it's not feasible for me to issue new releases of every library each time there's a minor dependency bump. In practice this is only worth the effort if there's a significant security fix.

Otherwise would encourage folks to use something like lein ancient to monitor their transient dependencies for potential updates.

Encore will always safe to update, so long as you stick to the same major version number. (So 2.x is safe to update to 2.y, 3.x is safe to update to 2.y, etc.).

Some more info re: manually controlling encore version here.

Hope that's of some help, at least!

Will keep this issue open in the meantime for other folks that might run into the same issue.

Cheers :-)

ptaoussanis commented 2 years ago

Ah, excuse me- I just noticed that you're asking specifically about upgrading from Encore v2.x to v3.x. That should also be okay, but would require double checking. I'll try take a look this weekend - otherwise you could also try to just switch to the latest (v3.x) version. If it builds okay, it should be fine - would just recommend double checking your usual unit tests, etc.

dharrigan commented 2 years ago

Thank you, will give it a whirl and hope for the best :-)

ptaoussanis commented 2 years ago

Just confirming that you should indeed be good-to-go with updating from Encore v2 to latest v3 👍

The only breaking change was a bump to the minimum Clojure dependency, and an opt-in removal/renaming of some vars (which won't affect you by default).

dharrigan commented 2 years ago

Thank you! That is very encouraging news.