search

taoensso / faraday

Amazon DynamoDB client for Clojure
https://www.taoensso.com/faraday
Eclipse Public License 1.0
238 stars 84 forks source link

Upgrade to 1.11.16+ of aws-sdk-java for task-level IAM role support in AWS ECS #113

Closed codeasone closed 4 years ago

codeasone commented 7 years ago

My application is running in an AWS ECS container that has task-level IAM policy associated with it.

Support for assuming task roles via the default credentials provider chain was added to aws-sdk-java in version 1.11.16

Please consider upgrading to a 1.11.16 or later release of the SDKs as part of the next release.

I have a fork which I'm using to work-around this issue. I've used 1.11.126 and am not seeing any significant issues.

However, I did see one error running the tests.

ricardojmendez commented 7 years ago

I have a fork which I'm using to work-around this issue. I've used 1.11.126 and am not seeing any significant issues.

Can you make a pull request?

codeasone commented 7 years ago

@ricardojmendez I just bumped the version in the project.clj, which doesn't justify a PR.

codeasone commented 7 years ago

A simple work-around for this limitation is simply putting the amazon SDK dependency ahead of faraday in your project.clj e.g: 

[com.amazonaws/aws-java-sdk-dynamodb "1.11.126"]
[com.taoensso/faraday "1.9.0"]
zarkone commented 7 years ago

@codeasone sorry, but why it doesn't justify a PR? I would be glad to remove this line from deps

codeasone commented 7 years ago

Why would you remove the dependency aws-java-sdk-dynamodb, which is required - perhaps I'm not understanding what you mean by:

[...] remove this line from the deps

Here is a PR to bump the version to the one my current projects uses, and which addresses the original issue without having to mitigate via Clojure's dependency resolution process. https://github.com/ptaoussanis/faraday/pull/117

./run-tests local reported no failures for me.

zarkone commented 7 years ago

@codeasone Sorry that my words was not clear...

Before, you suggested to add 1.11.126 to project.clj before faraday to workaround this issue. This is what I did, and it works for me. But I would be glad to remove this dependency from my project.clj, not faraday's, i.e. have this dependency updated inside faraday. So, thanks for your PR!

lilactown commented 6 years ago

How did you guys configure faraday to use dynamodb without providing credentials?

belucid commented 5 years ago

Part of 1.10. Beta forthcoming.

jvtrigueros commented 5 years ago

@Lokeh not to add too much noise to this issue, but you have to provide credentials, if you're looking to use DynamoDB Local (which requires no credentials) add these in your client-opts:

{:access-key ""
 :secret-key ""}