search

taoensso / faraday

Amazon DynamoDB client for Clojure
https://www.taoensso.com/faraday
Eclipse Public License 1.0
238 stars 84 forks source link

Bump aws-java-sdk version #125

Closed zaibacu closed 4 years ago

zaibacu commented 5 years ago

There are some breaking changes between 1.10.x and 1.11.x versions, most of tools now require 1.11.x, while faraday crashes with later version.

Just by bumping all the issues seems to be resolved and tests passes. deps.edn is here only to be able to include this package via git/url, which allows us to use this version without waiting for pull request to be accepted.

zaibacu commented 5 years ago

Seems to be linked with https://github.com/ptaoussanis/faraday/issues/113 , however ages have passed and still no bump in version.

bowbahdoe commented 4 years ago

Is the deps.edn needed for this?

zaibacu commented 4 years ago

Deps.edn is only used to be able to include this lib from git, because we actually need this fix in production.

I can remove it manually in this pull request, but we actually need it in fork branch