search

taoensso / faraday

Amazon DynamoDB client for Clojure
https://www.taoensso.com/faraday
Eclipse Public License 1.0
238 stars 84 forks source link

Fix merging of results for batch-get results #126

Closed neilprosser closed 4 years ago

neilprosser commented 5 years ago

I found that when using batch-get-item I was only receiving the final page of results for a table when the data ended up spanning multiple requests.

For example with the test example I've added I would only receive 45 items when getting 100 items. This was the second page of results because it had overwritten the first page of results in the merged results.

neilprosser commented 4 years ago

Here you go @joelittlejohn. I feel more confident about this PR now!

neilprosser commented 4 years ago

Sorry. I forced another bit into this to change a confusingly named variable in my tests.