taoensso / faraday

Amazon DynamoDB client for Clojure
https://www.taoensso.com/faraday
Eclipse Public License 1.0
238 stars 84 forks source link

Avoid request 'stitching' when span-reqs is not specified #143

Closed joelittlejohn closed 4 years ago

joelittlejohn commented 4 years ago

Until now, the default 'span-reqs' configuration stitched up to 5 requests together if last-prim-kvs implied it was necessary. This caused confusion because it's not getting all results but it's also not limited to just one page. The limit parameter also then became confusing, because the number of items returned by a request would be somewhere between '5' and '5 x limit'.

After this commit the various 'get items' functions will return only one page by default and if subsequent pages are needed then span-reqs must be used.

Closes #74

joelittlejohn commented 4 years ago

This is the kind of minor breaking change that Faraday has typically accepted via break versioning. We'll move from 0.10.x to 0.11.x to do this.