search

taoensso / faraday

Amazon DynamoDB client for Clojure
https://www.taoensso.com/faraday
Eclipse Public License 1.0
238 stars 84 forks source link

Support Custom protocol #157

Closed ravilaudya closed 3 years ago

ravilaudya commented 3 years ago

Support Custom protocol option (HTTP/HTTPS) defaults to HTTPS.

joelittlejohn commented 3 years ago

Hi Ravi. I'm interested to know why you need this feature. Do you work in environment that only allows http?

ravilaudya commented 3 years ago

To explain the intent for this PR - We have a scenario : Our app needs to call dynamo with only HTTP so that envoy (sidecar) interprets the call and does the HTTPS connection

ravilaudya commented 3 years ago

Hi Ravi. I'm interested to know why you need this feature. Do you work in environment that only allows http?

I have just added comment. Hope that explains.

ravilaudya commented 3 years ago

@joelittlejohn would it be possible to create a new release / tag when this PR is merged? We need some changes from master branch which are not there in 1.11.1 tag.

ravilaudya commented 3 years ago

@joelittlejohn can you suggest if you can review and merge this PR or is there any other person that I need to follow up with? thanks!

joelittlejohn commented 3 years ago

@mouryaravi Are you able to add a line to this test please:

https://github.com/Taoensso/faraday/blob/master/test/taoensso/faraday/tests/main.clj#L71

Once that's done I'm happy to merge and release 1.11.2

ravilaudya commented 3 years ago

I have added the tests. Thanks for the reminder @joelittlejohn

joelittlejohn commented 3 years ago

@mouryaravi This is released now: [com.taoensso/faraday "1.11.2"]