search

taoensso / faraday

Amazon DynamoDB client for Clojure
https://www.taoensso.com/faraday
Eclipse Public License 1.0
238 stars 84 forks source link

String index names cause type error #159

Closed JonathanHarford closed 3 years ago

JonathanHarford commented 3 years ago

It seems that the intent of #121 was to allow both keywords and strings as table/index names, but it seems like there was a regression in subsequent change (quite likely ee2e65d8634cb97f9a339454d3e2481e72971c95) that made it so string index/table names cause a type error: java.lang.ClassCastException: java.lang.String cannot be cast to clojure.lang.IFn

Was this an intentional change? We're happy to work on a patch if not.

You can reproduce this by changing bulk-table in tests/main.clj to a string.

kipz commented 3 years ago

Thanks for the bug report @JonathanHarford, and for all the digging.

It does look like a regression has sneaked in here.

A PR with the modified test passing would be most welcome!

JonathanHarford commented 3 years ago

Great, I'll tackle it later this week.

joelittlejohn commented 3 years ago

Closed by #160.