search

taoensso / faraday

Amazon DynamoDB client for Clojure
https://www.taoensso.com/faraday
Eclipse Public License 1.0
238 stars 84 forks source link

Possibly confusing dependencies found #163

Closed bitti closed 2 years ago

bitti commented 2 years ago

Currently the build for a project which contains the [com.taoensso/faraday "1.11.4"] dependency with :pedantic true is failing due to:

Possibly confusing dependencies found:
[com.taoensso/faraday "1.11.4"] -> [com.taoensso/encore "2.127.0"] -> [org.clojure/tools.reader "1.3.2"]
 overrides
[com.taoensso/faraday "1.11.4"] -> [com.taoensso/nippy "2.15.3"] -> [org.clojure/tools.reader "1.3.3"]

Consider using these exclusions:
[com.taoensso/faraday "1.11.4" :exclusions [org.clojure/tools.reader]]

Since com.taoensso/encore has the same project owner it shouldn't be a problem to get the versions of org.clojure/tools.reader aligned?

kipz commented 2 years ago

Thanks @bitti - shall we try to get the version upgraded in encore since it's older?

Oh wait, we are on really old encore...I guess we should try to update it.

bitti commented 2 years ago

Sure if you can update it that may be the best solution but thanks for the quick exclusion fix!

kipz commented 2 years ago

@bitti upgrading the major version looks like it could have a few issues, so perhaps this could do for now? Or perhaps you'd be up for a PR? I think this came up before..... @joelittlejohn?

Happy to re-open if you'd prefer?