search

taoensso / faraday

Amazon DynamoDB client for Clojure
https://www.taoensso.com/faraday
Eclipse Public License 1.0
238 stars 84 forks source link

Added some tests and fixed a boolean related issue #47

Closed tcoupland closed 9 years ago

ptaoussanis commented 9 years ago

Hi Tom, thanks for this.

I'm not keen on including all of the DDB binary files in the repo though. Perhaps we could add a get-ddb-local bash script which pulls in all the [latest? versioned?] files for folks that want them? We can then add the default destination to the .gitignore.

Will look over the other changes in detail if you can update the PR.

Thanks again, much appreciated!

Cheers :-)

tcoupland commented 9 years ago

Ok, i've made the test script download them on the first run in 'local' mode.

ptaoussanis commented 9 years ago

Thanks! Could you clean up the commit history so that the bin files never appear? Otherwise we're still adding all the files to the repo history.

Will also make it easier for me to check what this PR is actually changing. Cheers :-)

tcoupland commented 9 years ago

I've bfg'd those binaries and they seem to be gone when i check out the repo now.

I've found some extra stuff that needs to be added, around expectations for updates. So i'll close this request and open a new one when we've got to the end of what we're doing here.