taoensso / faraday

Amazon DynamoDB client for Clojure
https://www.taoensso.com/faraday
Eclipse Public License 1.0
238 stars 84 forks source link

Looking for feedback on upcoming Faraday v1.9 release #88

Closed ptaoussanis closed 8 years ago

ptaoussanis commented 8 years ago

[com.taoensso/faraday "1.9.0-alpha3"] is now up on Clojars with a significant set of changes. Big thanks to @ricardojmendez for the bulk of this work.

I don't use DynamoDB myself so would ask for a quick show of hands if the proposed changes for v1.9 look good to everyone. If anything's of concern, now would be the best time to report.

If anyone has some time + feels like helping out, would appreciate confirmations of alpha3 running okay on internal/application tests, etc. Please report any unexpected problems / breakages.

Pinging: @paraseba, @tlipski, @joelittlejohn, @moea, @mantree, @leonardoborges

Thanks a lot, hope everyone's having a good holiday season! Cheers :-)

joelittlejohn commented 8 years ago

Hey @ptaoussanis. Thanks for mentioning this, looks like there are some great changes in this release.

I integrated 1.9.0-alpha3 into a selection of our services and ran their test suites. After the required changes for update-item all tests ran successfully. We can consider this at least a basic sanity check for:

as-map
batch-get-item
batch-write-item
clj-item->db-item
delete-item
delete-item-request
delete-table
describe-table
ensure-table
freeze
get-item
list-tables
put-item
put-item-request
query
query-request
update-item

I can't really comment on how exhaustive these tests are (it varies :smile:), but hopefully that will give you a little confidence.

ptaoussanis commented 8 years ago

@joelittlejohn Exactly what I was looking for, thanks Joe!

ptaoussanis commented 8 years ago

@ricardojmendez Hi Ricardo, wanted to get your input on the current v1.9 dev branch- is it essentially API stable?

Am ready to publish a public beta whenever you give me the go-ahead.

Thanks! :-)

ricardojmendez commented 8 years ago

Hi Peter,

I have no breaking changes planned. I expect the API will remain as is, and we can later figure out how to best support the new APIs separately (probably under a different namespace).

I'd say go ahead!

ptaoussanis commented 8 years ago

Done! Thanks-