Using grease for ByteArrayIO

taoensso / nippy

The fastest serialization library for Clojure

https://www.taoensso.com/nippy

Eclipse Public License 1.0

1.04k stars 60 forks source link

Using grease for ByteArrayIO #11

Closed mpenet closed 11 years ago

mpenet commented 11 years ago

Hi Peter,

I pushed a version of nippy using the latest grease and ran tests on carmine using it. It compiles fine now, you can see for yourself using this branch: https://github.com/mpenet/carmine/tree/clojars

the build on travis for carmine using this nippy build: https://travis-ci.org/mpenet/carmine/builds/8209037
the nippy build in question https://travis-ci.org/mpenet/nippy

ptaoussanis commented 11 years ago

Should we not be concerned about the -target arg? I feel like I've had some trouble with that in the past when doing AOT, etc.

mpenet commented 11 years ago

From what I have read I dont believe so, but I haven't tried. Since it's an external dependency, compiled as 1.6 compatible, it should run fine on 1.6+.

It's worth noting that large projects such as cassandra/elasticsearch that support both jdks must do the same (since they use the same classes).

Unless I am missunderstanding what you mean or missing something. Also I have very little experience with AOT.

ptaoussanis commented 11 years ago

Well let's give it a shot - simple enough to undo if anyone has any problems (esp. in this form as an external dep). Like the idea of grease btw.

ptaoussanis commented 11 years ago

Oh, is it greased? Thought I saw it as grease somewhere.

mpenet commented 11 years ago

It's grease, I just named the branch like that (don't ask, there is no rational explaination :))