Ensure length of medium sized keyword is written as a Short.

taoensso / nippy

The fastest serialization library for Clojure

https://www.taoensso.com/nippy

Eclipse Public License 1.0

1.04k stars 60 forks source link

Ensure length of medium sized keyword is written as a Short. #138

Closed danmason closed 3 years ago

danmason commented 3 years ago

Hello there! We were recently trying to bump nippy versions within Crux, though we ran into some issues within our tests. I wrote up my findings in more detail here https://github.com/juxt/crux/pull/1249#issuecomment-729085399, but essentially it was caused by this line within write-kw where the length of a medium sized keyword was being written as an Integer rather than a Short.

ptaoussanis commented 3 years ago

@danmason Thanks for the report Dan, and apologies for the trouble! Just pushed [com.taoensso/nippy "3.1.1"] to Clojars, which includes your fix.

danmason commented 3 years ago

@ptaoussanis Much appreciated - I'll give it a go and run it through our tests! Thank you.