taoensso / nippy

The fastest serialization library for Clojure
https://www.taoensso.com/nippy
Eclipse Public License 1.0
1.04k stars 60 forks source link

adding mikera/vectorz to thaw allowlist #139

Closed danielfleischer closed 3 years ago

ptaoussanis commented 3 years ago

Hi there! Has someone verified that all the targeted classes are safe? What's the level of confidence?

Thanks

danielfleischer commented 3 years ago

I've used the Vector and AVector classes, but I'm not aware of any official verifications.

See vectorz and the clojure bindings vectorz-clj for more detail.

ptaoussanis commented 3 years ago

Hi there!

Unfortunately I don't think this'd make sense to add to the default list for a couple reasons:

  1. Someone would need to properly investigate to check that there's no security risk posed by any of the classes. This is a solvable problem but would take some work.
  2. I'm not sure that this library is common enough to warrant inclusion in the defaults.

Why does 2. matter?

Would recommend you just add the classes you need to your own configuration.

Hope this makes sense!

Cheers :-)

danielfleischer commented 3 years ago

Hi, thanks for the clarification, it makes perfect sense.