search

taoensso / nippy

The fastest serialization library for Clojure
https://www.taoensso.com/nippy
Eclipse Public License 1.0
1.04k stars 60 forks source link

2.6.0 and 2.6.1 breaks clojure backward compatibility #46

Closed kul closed 10 years ago

kul commented 10 years ago

My project was based on clojure 1.4 and nippy 2.5.2, upon upgrade to 2.6.0 or 2.6.1 i get 

user=> (use 'taoensso.nippy)

FileNotFoundException Could not locate clojure/edn__init.class or clojure/edn.clj on classpath:   clojure.lang.RT.load (RT.java:432)
user=> (pst)
FileNotFoundException Could not locate clojure/edn__init.class or clojure/edn.clj on classpath: 
        clojure.lang.RT.load (RT.java:432)
        clojure.lang.RT.load (RT.java:400)
        clojure.core/load/fn--4890 (core.clj:5415)
        clojure.core/load (core.clj:5414)
        clojure.core/load-one (core.clj:5227)
        clojure.core/load-lib (core.clj:5264)
        clojure.core/apply (core.clj:603)
        clojure.core/load-libs (core.clj:5298)
        clojure.core/apply (core.clj:603)
        clojure.core/require (core.clj:5381)
        taoensso.encore/eval1956/loading--4784--auto----1957 (encore.clj:1)
        taoensso.encore/eval1956 (encore.clj:1)
nil
ptaoussanis commented 10 years ago

Hi kul,

Could you try run lein clean and restart your project? Does that help?

kul commented 10 years ago

No it still doesnt help, Are you not able to reproduce this?

ptaoussanis commented 10 years ago

Could you show me the contents of your lein :deps tree? Are there any conflicts?

kul commented 10 years ago 
; % lein deps :tree
 [clojure-complete "0.2.3" :exclusions [[org.clojure/clojure]]]
 [com.taoensso/nippy "2.6.1"]
   [com.taoensso/encore "1.1.0"]
   [org.clojure/tools.reader "0.8.3"]
   [org.iq80.snappy/snappy "0.3"]
   [org.tukaani/xz "1.5"]
 [org.clojure/clojure "1.4.0"]
 [org.clojure/tools.nrepl "0.2.3" :exclusions [[org.clojure/clojure]]]
 [slamhound "1.5.0"]
ptaoussanis commented 10 years ago

Ahh, spotted the problem - it's a bug. Give me a few minutes and I'll push a fix.

Thanks for the report!

ptaoussanis commented 10 years ago

Okay, pushed v2.6.2: https://github.com/ptaoussanis/nippy/releases/tag/v2.6.2 Sorry for the delay, on a painfully slow net connection atm.

kul commented 10 years ago

Awesome! Thanks @ptaoussanis!

kul commented 10 years ago

I would like to suggest to have a profile for each clojure version you would like support. Currently i see 1.4 dont have any profile. Also integration with travis would be nice to run test against each profile.

2 cents.

ptaoussanis commented 10 years ago

No problem :-)

1.4 doesn't have a profile because it's in the base profile. I'm not a fan of Travis, but lein test-all will test against all versions including 1.4.

Hope that helps, cheers!