search

taoensso / sente

Realtime web comms library for Clojure/Script
https://www.taoensso.com/sente
Eclipse Public License 1.0
1.74k stars 193 forks source link

Server adapter for Macchiato Framework on Node.js #307

Closed theasp closed 5 years ago

theasp commented 7 years ago

https://macchiato-framework.github.io/

This needs the following to have a working session, and csrf token: https://github.com/macchiato-framework/macchiato-core/pull/20

theasp commented 7 years ago

Example is here: https://github.com/theasp/sente-nodejs-example/tree/macchiato

theasp commented 6 years ago

@ptaoussanis Hi Peter, I'm sure you are just busy, but is there anything I can do to move this PR along?

ptaoussanis commented 5 years ago

He Andrew, really sorry for the delay- merging manually now.

ptaoussanis commented 5 years ago

Hi @theasp,

Merging this seems to cause lein cljsbuild once to fail with:

Caused by: clojure.lang.ExceptionInfo: No such namespace: macchiato.middleware.anti-forgery, could not locate macchiato/middleware/anti_forgery.cljs, macchiato/middleware/anti_forgery.cljc, or JavaScript source providing "macchiato.middleware.anti-forgery" (Please check that namespaces with dashes use underscores in the ClojureScript file name) in file src/taoensso/sente/server_adapters/macchiato.cljs {:tag :cljs/analysis-error}

Am unfortunately a little short on time so can't look closer to debug; could you please advise?

Thanks!

theasp commented 5 years ago

Hi @ptaoussanis, it just needed a dep on macchiato/core for :dev.

ptaoussanis commented 5 years ago

Thanks, merged :+1: