search

taoensso / sente

Realtime web comms library for Clojure/Script
https://www.taoensso.com/sente
Eclipse Public License 1.0
1.73k stars 193 forks source link

Allow user to set a host different from the window location #370

Closed wilkerlucio closed 4 years ago

wilkerlucio commented 4 years ago

I tried to use a custom host from an electron app and notice that the host was always going blank. Looking at the code, the host param was being shadowed by the internal host on the let. This change fixes it so it first tries to use the user-defined host instead of reading from the window location.

wilkerlucio commented 4 years ago

@ptaoussanis seems like there is a lot of PR's open, this is very important because not being able to do this setting makes sense unusable in many environments, it seems a simple enough fix on the PR #366 , is that any blocker or concern preventing this fix from release? Cheers.

ptaoussanis commented 4 years ago

Apologies for the delay on this, have just been swamped. Addressing now - thanks Wilker!