search

taoensso / sente

Realtime web comms library for Clojure/Script
https://www.taoensso.com/sente
Eclipse Public License 1.0
1.74k stars 193 forks source link

Add support for websocket-connection options #390

Closed KaliszAd closed 2 years ago

KaliszAd commented 3 years ago

The use-case is e.g. if you want to send larger WS messages. The max-frame-payload is 65536 bytes and max-frame-size is 1048576 bytes by default. It seems, the disassembly/ reassembly of frames isn't supported in some scenarios but there is still need for larger data transfer over WS. Therefore the easiest solution is to just increase the max-frame-payload size. Aleph currently has 7 options to configure more appropriate settings in less common circumstances.

If no map of options is provided, the code works as before and is therefore to the best of my knowledge backwards compatible.

KaliszAd commented 3 years ago

@ptaoussanis would you consider merging the PR or is there anything else I have to do?

ptaoussanis commented 3 years ago

Hi Adam, I'm expecting to have time in July to work on open source again- will take a look at this then!

ptaoussanis commented 2 years ago

@KaliszAd Hi Adam, merging this manually now - apologies for the big delay!