search

taoensso / sente

Realtime web comms library for Clojure/Script
https://www.taoensso.com/sente
Eclipse Public License 1.0
1.73k stars 193 forks source link

`generic-node-adapter` not working on node v14.18.0 #392

Closed lane-s closed 1 year ago

lane-s commented 2 years ago

It seems like at some point, the type of the data passed to the we socket "message" event callback changed from string to Buffer, which needs to be handled by the adapter (probably by simply doing (.toString data) when passing the data on to sente). Otherwise the invariant at taoensso.sente:208 is violated and no message can be received without crashing the server.

ptaoussanis commented 1 year ago

Is this report perhaps obsolete due to #398, #404?

I'm not too familiar with Sente+node, would be helpful if someone more familiar could take a look and comment!

ptaoussanis commented 1 year ago

Closing as part of issue triage since I believe this may already be resolved on master. Please feel free to re-open if this issue is still relevant!