search

taoensso / sente

Realtime web comms library for Clojure/Script
https://www.taoensso.com/sente
Eclipse Public License 1.0
1.74k stars 193 forks source link

Start ws-kalive loop after connection is established #403

Closed Snurppa closed 2 years ago

Snurppa commented 2 years ago

Now the :chsk/ws-ping go-loop starts before (connect-fn) is called. If a connection in (connect-fn) can't be established right away, it will enter (retry-fn) loop, until WS conn socket is established. Maybe it takes forever, maybe it takes just 10 seconds for the remote end to come online.

Meanwhile, we are sending ourselves the pings in ws-kalive-ms intervals. Basically means log gets polluted with both: "Chsk send against closed chsk." from the ws-ping send, and "Chsk is closed: will try reconnect" from the connection retry-fn.

This change will start the go-loop only after we have returned from (connect-fn).

ptaoussanis commented 2 years ago

@Snurppa Hi Joni, thanks for this - merging manually now!