search

taoensso / sente

Realtime web comms library for Clojure/Script
https://www.taoensso.com/sente
Eclipse Public License 1.0
1.73k stars 193 forks source link

Example project browser auto-start exception #432

Closed krajj7 closed 11 months ago

krajj7 commented 11 months ago

Just a minor suggestion.

The example project does this: https://github.com/ptaoussanis/sente/blob/7f5adb25e3e3bec05102ef08034c50082cd29f13/example-project/src/example/server.clj#L329-L331

On my system with OpenJDK 17.0.8-ea+6-Debian-3 this causes the following exception:

UnsupportedOperationException The BROWSE action is not supported on the current platform!

This exception is not caught and it prevents part of the demo from starting (the broadcast loop).

So I suggest making it catch all Exceptions instead (it's no big deal if the browser doesn't autostart), or add UnsupportedOperationException.

ptaoussanis commented 11 months ago

Thanks for pinging about this! Will include with the other example changes 👍