Inbility to resolve parsed EDN symbol when upgrading to 1.0.0-beta1

billtuba commented 4 months ago

Description

When upgrading to 1.0.0-beta1 ( from 1.0.0-alpha1) I noticed if I pass JVM arg -Dtaoesnsso.timbre.config.edn=some-symbol - some-symbol is not being evaluated.

Steps to reproduce

Gist
(its a clj tools project)

OS/Java version

Description: Ubuntu 22.04.3 LTS Release: 22.04

openjdk version "17" 2021-09-14 OpenJDK Runtime Environment Temurin-17+35 (build 17+35) OpenJDK 64-Bit Server VM Temurin-17+35 (build 17+35, mixed mode, sharing)

Notes

If I do a diff on the dependency trees (alpha vs beta) I get :

< com.taoensso/tempel 1.0.0-alpha1
<   . com.taoensso/encore 3.74.0
<     . org.clojure/tools.reader 1.3.6
---
> com.taoensso/tempel 1.0.0-beta1
>   . com.taoensso/encore 3.76.0
>     . org.clojure/tools.reader 1.3.7

In encore between 3.74.0 and 3.76.0 I noticed this .

It looks like the feature that resolves edn symbols was removed ?

Is the feature deprecated or is there another way to achieve the same effect?

I didn't know if I should file this ticket here or not. Thanks!

ptaoussanis commented 4 months ago

@billtuba

Hi Bill, thanks for pinging about this - and for the excellent+clear report 👍 Helped make it much easier to investigate 🙏

The behaviour you're seeing was indeed an unintended regression, really sorry about the trouble! I've been doing a lot of work on Encore's config API recently, haven't gotten around to updating Timbre yet, and I missed this particular backwards-compatibility case.

Have just pushed a fix to Encore. Your test project now works okay on my end when including the latest version ({com.taoensso/encore {:mvn/version "3.80.0"}}).

But please ping if you still have any more trouble.

Happy weekend, cheers! :-)

billtuba commented 4 months ago

We used the new encore lib, our current timbre and the beta1-tempel...

Works perfectly!! Thanks @ptaoussanis for the quick turnaround. Sorry it took me so long to get back to you to confirm.

ptaoussanis commented 4 months ago

No worries, thanks for the confirmation 👍 Happy weekend, cheers :-)

taoensso / tempel