taoensso / timbre

Pure Clojure/Script logging library
https://www.taoensso.com/timbre
Eclipse Public License 1.0
1.44k stars 171 forks source link

Replace usages of io.aviso/pretty with org.clj-commons/pretty #381

Closed hlship closed 4 months ago

hlship commented 7 months ago

The main issue is that anyone who is using customized fonts (as per the documentation on the wiki) will see failures, because the values have changed from strings to keywords.

This may warrant a major version upgrade in Timbre, or at least, a strongly worded note in the change log.

hlship commented 7 months ago

A further note: org.clj-commons/pretty has built-in checks for whether its likely that output is directed to a console or not; in the latter case, ANSI formatting codes (font and color) are eliminated automatically; I'm not sure who logs to a file with ANSI formatting, but that's likely going to be an explicit opt-in (there's a system property that can be set to override the normal check).

ptaoussanis commented 7 months ago

Thank you very much Howard! I'll definitely take a closer look at merging this when I'm next on batched Timbre work 👍

Cheers :-)

ptaoussanis commented 4 months ago

Will be addressed in upcoming release, closing 👍