search

taoensso / tower

i18n & L10n library for Clojure/Script
https://www.taoensso.com/tower
Eclipse Public License 1.0
278 stars 24 forks source link

Warn about `dev-mode?` in readme and changelog? #73

Open timmc opened 8 years ago

timmc commented 8 years ago

I know the library is EOL, but could you add a warning to the README about dev-mode? so that people will turn it off in production?

I just discovered that one of our servers was experiencing periodic hangs due to threads blocked on re-reading the jar file every time a translation was needed. This might no longer be relevant in v3 -- I couldn't quite tell from the changelog -- but the server uses v2.0.1 and this took some time to debug since dev-mode isn't documented.

The README currently implies that dev-mode is off by default ("Enable the :dev-mode? option and you're good to go!"; various places where it is shown as explicitly enabled) -- a "hey, turn this off in prod" would be great.

I could send a PR if that would be helpful.

ptaoussanis commented 8 years ago

Hi Tim, sorry about that!

The README currently implies that dev-mode is off by default

My apologies, the default does appear to be on by default (incl. for the latest release). Would definitely be up for a README PR.

Much appreciated!