search

taok-monitor / taok-front

Front-end do projeto TaOk-Monitor
https://taok-monitor.github.io/
MIT License
3 stars 2 forks source link

New Component to manager Legends #16

Closed cassunde closed 5 years ago

cassunde commented 5 years ago

Task

15

Goal

Refactore Bar Component, moving all code about legend to Legend component

cassunde commented 5 years ago

Maybe this component can be irrelevant, because this information can be displayed using this function

function getFormattedLabel(tooltipItem, data)

with this we can saves space on the page, you agree ? What do you think ?

samuelsilvadev commented 5 years ago

I see.. humm..., I liked to see the legend below the chart, but I agree that it's useless since the user can see on the chart directly.

about the space I think the page always can grow so it's not a problem.

samuelsilvadev commented 5 years ago

if you think it's better without this component I agree too, it was just a personal taste for the matter :D

cassunde commented 5 years ago

Ok, let's create a new issue to include the caption in the chart, today I update this pr with changes

cassunde commented 5 years ago

close this pr because the pr #20 best represents the solution to issue #15