search

taoqf / node-html-parser

A very fast HTML parser, generating a simplified DOM, with basic element query support.
MIT License
1.11k stars 107 forks source link

Fix 144 #148

Closed nonara closed 3 years ago

nonara commented 3 years ago

Related Issues

Performance Notes

When I said it wouldn't have a perf impact, I should have more correctly stated that the impact would be negligible.

I did a bit of perf testing and found that the added operation: if (myVar === 'a' || myVar === 'A') runs at 436,132,968 ops per second. The extra bit of logic inside the conditional will be even less impactful, as it will rarely execute, and is also extremely inexpensive.

In short, I don't expect a noticeable difference for the changes.

nonara commented 3 years ago

@taoqf Looks like you've got a bit going on that's keeping you busy. Would you be willing to make me a maintainer so I can help keep things moving and address some of the issues?

For some background, I understand the priority of speed, and I maintain several large / critical repos. I'd be happy to help.

Also, I have a month old ticket waiting on this — at the very least, can we merge this PR?

taoqf commented 3 years ago

@nonara Happy to hear this.

taoqf commented 3 years ago

Busy is not the only thing stop me, but also the gfw. I am not access to github for month.

nonara commented 3 years ago

Thanks! Will be glad to help out. Sorry to hear about that. I didn't realize the GFW was blocking GitHub!