search

taoqf / node-html-parser

A very fast HTML parser, generating a simplified DOM, with basic element query support.
MIT License
1.12k stars 112 forks source link

Fix #17 #23

Closed Sharcoux closed 3 years ago

nonara commented 3 years ago

Doing a little housekeeping. Is this PR something that still needs to be reviewed?

Sharcoux commented 3 years ago

Probably better to report the changes than review. The version is too old. The only thing worth doing here is check the error thrown by setAttributes if the parameters are wrong and see if it's helping in case of debugging. Otherwise, this can be closed.

nonara commented 3 years ago

Thanks! I'm going to go ahead and close, but I agree that more verbosity could be useful. If you'd like to open a new PR with the change, we can see if Tao agrees and merge.

Sharcoux commented 3 years ago

I kept using my fork actually. I liked more the previous architecture ;)