taoteh1221 / Open_Crypto_Tracker

Bitcoin / Alts private portfolio tracker, with email / text / alexa / telegram price alerts, charts, leverage support and much more.
https://taoteh1221.github.io
GNU General Public License v3.0
97 stars 23 forks source link

An issue with the update tab #22

Closed s1-ranjan closed 3 years ago

s1-ranjan commented 3 years ago

As of now update tab is taking more width than the default screen resolution so it would be nice if the update table fits well with the screen resolution in order to prevent the horizontal scrolling.

s1-ranjan commented 3 years ago

my screen resolution is 1440x900 (16:10)

taoteh1221 commented 3 years ago

@s1-ranjan This is not possible, as this is only happening because the content in the update page is wider than your screen. You have no empty page space on either side of the update page on the left a right sides of the page, correct?

s1-ranjan commented 3 years ago

yes, you are correct @taoteh1221 that does not look good.

taoteh1221 commented 3 years ago

Could you please send me a screenshot @s1-ranjan ?

s1-ranjan commented 3 years ago

@taoteh1221 , I am including a screenshot please have a look Screenshot from 2021-08-26 23-18-55...

taoteh1221 commented 3 years ago

Looks like the content is taking up your whole screen width, and even more than that. I'm guessing you have one or two coin rows there that are wider than your screen, right? I don't think there is anything we could do except make the text font smaller, if that's the case here (which would look worse than it does now). It would be nice to see all the coin rows in your screenshot if you could, so I can get a better idea of what's going on here.

s1-ranjan commented 3 years ago

Well, I tried to get all the coins from the list in the screenshot but in the screenshot, there are no issues so I recorded my screen and I am sharing it with you with the hope this can help in figuring out the issue with the page. Screenshot 2021-08-27 at 15-11-54 Open Crypto Portfolio Tracker Podcast-20210827151121-Linux-Mint.mp4.zip

taoteh1221 commented 3 years ago

Thanks for the the better screenshot @s1-ranjan . I'm sorry to say there isn't really anything feasible we can do about this. As you can see the "Misc. INR Value" data row is requiring the extra screen width. If we make the font smaller, then it risks being too hard to read. I hope this makes sense.

s1-ranjan commented 3 years ago

why not to apply CSS tweak of flux setting for the table part this may can fix the issue.

s1-ranjan commented 3 years ago

A second solution that can be applied would be by splitting the all the coin rows in two-line as: First-line for the name of coin currency @ market and the remaining part i.e., from the holding to the end of the line in the second part, I regard this may accommodate all the page content in the single page without any horizontal scrolling.

taoteh1221 commented 3 years ago

why not to apply CSS tweak of flux setting for the table part this may can fix the issue.

This is an issue with the longest data row being too wide for your screen to not make a horizontal scrollbar, which in my opinion it's not feasible to "fix" like I already said, because the ways to fix it would make things look worse than they do now on small screens like yours.

taoteh1221 commented 3 years ago

A second solution that can be applied would be by splitting the all the coin rows in two-line as: First-line for the name of coin currency @ market and the remaining part i.e., from the holding to the end of the line in the second part, I regard this may accommodate all the page content in the single page without any horizontal scrolling.

We don't want it to wrap to a second line as it's many rows of data and would be more cluttered / confusing that way. It's specifically designed to always force the data to stay on one line, and widen the page as needed. What if you wanted to follow 50 assets? You'd then have 100 lines of data, not even taking up the entire available screen width even on small screens. There is no feasible "fix" here for small screens like yours. I'm sorry for the bad news.