Closed gbowne1 closed 1 year ago
This would at least resolve Issue #28
LGTM!
@hitblast This has security vulnerabilities. The jQWidgets and Toastr libraries in /Libs both need re-downloaded and updated.. if indeed these were fixed in new versions.
I feel like we should be using Bootstrap 5.2 which has built in Toasts, PopperJS for poppers and jQueryUI for UI stuff.
I still feel like there are missing files.. but yeah, this should be the last of the missing files. I was just going through the stuff I downloaded from the orig repository before migrating to Org and found a few that reference files that are here already.
There are some things in the code that reference items from the libraries added back from this PR. This will fix the missing files but not fix vulnerabilities. I would strongly suggest changing as above. Review the security report.
I think I may have found the correct header.php
I will add it in the next PR.
Alright, seems reasonable. Also how about using Tailwind instead of Bootstrap?
At some point, yes. Lets get to 0.5.0 - 1.0.0 and we can talk about other dependencies.
We still need unit testing for the site. I am not a good test writer, but I can do UX/UI testing.
At this point @HritikR and I talked about jest since its easy and covers JavaScript, unless anyone else has other ideas. I don't know how well he tested.
I'm focused on getting back to where we were last when he was working on it.
With Bootstrap 5.2 it comes a lot of nice things.
Theres other CDN libraries I commented out we can look at. Modenizr, MaterialUI/Material.io, etc.
Hiya Greg
You should no longer use the JQWidgets library as they are personally licensed to me and I’ll need to use them in an upcoming project.
Cancer sucks going to chemo from the 30th September. Still feeling very tired. Fuego now has two way SMS with SMS history bound to Jobs and Quotes.
Hope you’re well!
Talk again sorry on
Kind regards
Ivan
Sent from my iPhone
On 16 Sep 2022, at 15:14, Gregory Bowne @.***> wrote:
This has security vulnerabilities. The jQWidgets and Toastr libraries in /Libs both need re-downloaded and updated.. if indeed these were fixed in new versions.
I feel like we should be using Bootstrap 5.2 which has built in Toasts, PopperJS for poppers and jQueryUI for UI stuff.
I still feel like there are missing files.. but yeah, this should be the last of the missing files. I was just going through the stuff I downloaded from the orig repository before migrating to Org and found a few that reference files that are here already.
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.
@idormain
I am going to be probably redoing tgis site anyways, if not to change the libraries it uses and remove the old ones because Toasts are built into Bootstrap 5 and I have found jQuery UI a lot better to use..
I would suggest to you if youre using Toasts for notifications etc to use Bootstrap. I would also suggest using any UI library other than jQWidgets.
I may even suggest Materialize.
I still need to get time to remove all the jQWidgets stuff from the actual site code. Some stuff wont work if I remove the library files
There is a jQWidgets and Toastr CDN as well but I cant tell whether the new versions have removed the security vulnerabilities.. another reason you or anyone else should not use it. Particularly because of the log4j security issues it has.
Is the radio logger server you created still running?
Cheers
This PR
There are well over 1k files in this PR because of the Libs folder, so no need to review that.
We still need to test and configure Visual Studio 2019 ~ 2022 for this project. Anyone have VS?
It also needs a IntelliJ, Atom and PHPStorm config folder, although I may have the original .idea folder from when @idormain was working on it.