[Refactoring] Method renaming

tapahob / BG2RadarOverlay

An overlay program for Baldurs Gate EE (1, 2) showing nearest enemies, their resistances, buffs and its durations

MIT License

27 stars 3 forks source link

[Refactoring] Method renaming #33

Closed LionAG closed 1 year ago

LionAG commented 1 year ago

A small pull request featuring method renaming to adhere to solution - wide naming convention.

Renamed private methods using camel case

tapahob commented 1 year ago

Thanks again @Nesae-avi !

Do you have any ideas for the project or you just want to tidy it up?

LionAG commented 1 year ago

One idea is to add a functionality that would (optionally - depending on the option toggle) display the item code when selecting it in the inventory / hovering over it.

tapahob commented 1 year ago

One idea is to add a functionality that would (optionally - depending on the option toggle) display the item code when selecting it in the inventory / hovering over it.

Hm, currently I have no pointers to the inventory screen so it would be kinda hard to find. What I did with the other pointers:

Searched to the memory location with Cheat Engine
looked at who accesses it,
retrieved the offset and the register address
looked who accesses this address and if its static or not
repeat the prev step til I find the static pointer

LionAG commented 1 year ago

Hm, currently I have no pointers to the inventory screen so it would be kinda hard to find.

I have done that. Is it alright to contact you on Discord? I think it'll be more convenient than using GitHub comments.

tapahob commented 1 year ago

Please do, can't promise a quick reply though - having tough time adapting to a new position