search

tapajos / highrise

Ruby wrapper around Highrise API.
MIT License
124 stars 77 forks source link

Rails 4 #49

Closed lucasmartins closed 11 years ago

lucasmartins commented 11 years ago

I've just updated activeresource version to be compatible with Rails 4, and removed Ruby version 1.9.2 from .travis.yml since Rails 4 requires 1.9.3+.

lucasmartins commented 11 years ago

Rspec tests keep passing, and I have tested saving a Person to my Highrise account with it, everything seems ok.

tapajos commented 11 years ago

I prefer don't change this dependency until Rails 4 is out. What do you think about have it in a branch with a beta version of the gem?

lucasmartins commented 11 years ago

Travis builds fail on: Errno::ENOENT: No such file or directory - /home/travis/.gem-private_key.pem

tapajos commented 11 years ago

@lucasmartins I pushed a fix for this issue.

https://travis-ci.org/tapajos/highrise

lucasmartins commented 11 years ago

Sure, I agree, I have created a rails-4 branch on my repo too.

tapajos commented 11 years ago

I will crete it tomorrow and push the gem for you. ok?

lucasmartins commented 11 years ago

Sure, thanks.