tapajos / highrise

Ruby wrapper around Highrise API.
MIT License
124 stars 77 forks source link

Person.tags doesn't always return a Highrise::Tag array #57

Open basvodde opened 10 years ago

basvodde commented 10 years ago

The current tags implementation (in taggable) uses get(:tags) which returns a Hash and not a Highrise::Tag. This causes trouble when adding tags and retrieving them later.

There are probably two solutions: 1) Pass the Hash to a create of the Highrise::Tag and return that (ugly) 2) Do a find instead of a get, so that the Hash gets recordized.

Other ideas welcome :) Fixed it locally but it breaks the taggable behavior as defined by the current specs, so will need more work before doing a PR