search

tapascript / solid-bucket-list

A simple bucket-list using the super powerful solidjs
https://youtube.com/@tapasadhikary
MIT License
16 stars 15 forks source link

Add useBucketList hook to manage bucket list items #11

Closed sarowarhosen03 closed 11 months ago

sarowarhosen03 commented 11 months ago

5

now bucket list items sync with local storage here im made up an custom hooks help of using createEffect from solid.js to sync the bucket items with localStorage more efficiently

netlify[bot] commented 11 months ago

Deploy Preview for solidbucketlist ready!

Name Link
Latest commit 524335d253a674db6bcc2dcf663ff76a090e1677
Latest deploy log https://app.netlify.com/sites/solidbucketlist/deploys/6555984f1f9bbf0008bf8fbc
Deploy Preview https://deploy-preview-11--solidbucketlist.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

atapas commented 11 months ago

@sarowarhosen03 I liked what you did in this PR.

Could you please take the latest code, resolve merge conflicts and then change things according to what went in for the localstorage implementation with signal?

sarowarhosen03 commented 11 months ago

@sarowarhosen03 I liked what you did in this PR.

Could you please take the latest code, resolve merge conflicts and then change things according to what went in for the localstorage implementation with signal?

Yes I can do it give me some time i will update my pr

atapas commented 11 months ago

@sarowarhosen03 I liked what you did in this PR. Could you please take the latest code, resolve merge conflicts and then change things according to what went in for the localstorage implementation with signal?

Yes I can do it give me some time i will update my pr

Cool... take ur time.. but look like u closed it. Also please create an issue for it.

sarowarhosen03 commented 11 months ago

@sarowarhosen03 I liked what you did in this PR.

Could you please take the latest code, resolve merge conflicts and then change things according to what went in for the localstorage implementation with signal?

Sir should i take dummy bucket list item as initial state. Or i will remove it and start with empty . I think Starting with empty is good one. What's your opinion

sarowarhosen03 commented 11 months ago

@sarowarhosen03 I liked what you did in this PR. Could you please take the latest code, resolve merge conflicts and then change things according to what went in for the localstorage implementation with signal?

Yes I can do it give me some time i will update my pr

Cool... take ur time.. but look like u closed it. Also please create an issue for it.

I discard my changes to sync with your master branch . I will create a new PR and issu with my updated code soon