upgrade the dependencies to their latest version - Githubissues

tape-testing / tape

tap-producing test harness for node and browsers

MIT License

5.77k stars 305 forks source link

upgrade the dependencies to their latest version #505

Closed osdevisnot closed 4 years ago

osdevisnot commented 4 years ago

This pr upgrades tap and tap-parser to their latest version. I also tool the opportunity to upgrade concat-stream.

Looking forward to any feedback.

Few notable upstream changes:

tap-parser changed the signature - requiring us to create a class with new keyword
tap-parser added a parser.fullname field - https://github.com/tapjs/tap-parser/commit/287e137f0dc5854acc636d1f0f46f4ff423db4b4 - my approach in this PR is to explicitly delete the parser.fullname property, but I can change the expectations too if that's more preferred.

osdevisnot commented 4 years ago

Looking at the test failures, we might need to update the supported node version based on dependencies.

Notably, tap started depending on async/await, const and other modern javascript features, which would require us to bump supported node version from ~1.0 to ~6.0 at least.

ljharb commented 4 years ago

We will likely never drop any version of node that's currently supported. There's a reason we haven't upgraded all of the dev deps :-)

osdevisnot commented 4 years ago

We will likely never drop any version of node that's currently supported. There's a reason we haven't upgraded all of the dev deps :-)

The motivation behind this PR is to be able to use the parallel testing feature introduced in tap version 13.

If I may ask, is there a specific reason to support node version if it reaches EOL status on node.js

ljharb commented 4 years ago

EOL status is irrelevant. People use it, and supporting it makes their platform upgrades easier.

Also, tape is used in browsers, and there are still people using IE 8 and 9.

tape’s tests are more than fast enough; parallel testing isn’t that much of a carrot for me.

osdevisnot commented 4 years ago

ok, makes sense. Feel free to close this PR unless we want to change the support policies.

ljharb commented 4 years ago

@osdevisnot i'm still interested in some of the changes here; if you can get concat-stream updated to v2, and improve the editorconfig check, that's still worth getting in.

osdevisnot commented 4 years ago

great, closing this in favor of #506.

ljharb commented 4 years ago

Looks like the concat-stream update isn't going to work in node < 4.

ljharb commented 4 years ago

As such, I'm going to close this and #506; since it turns out, every non-updated dev dep was because updating it would break things :-)