search

tape-testing / tape

tap-producing test harness for node and browsers
MIT License
5.77k stars 307 forks source link

[Tests] add test case for #519 for test.comment() in createStream/objectMode context #520

Closed DavidAnson closed 4 years ago

ljharb commented 4 years ago

oops! this wasn't linked to #519, so i committed fb94836 before realizing this was here.

DavidAnson commented 4 years ago

OK, thanks! Out of curiosity, how should I have linked it to the issue?

ljharb commented 4 years ago

Just referencing it with # and the number, like I did in my comment, would be sufficient :-) You can also comment on the issue with a similar reference to the PR number.

DavidAnson commented 4 years ago

I put “fixes ###” in the commit message and it did show up in the issue timeline. No worries here, just wanted to be sure I was doing things right.

ljharb commented 4 years ago

ah, you're right! however, a commit reference in the timeline is unfortunately a lot more subtle than a PR reference, so i missed it :-/

DavidAnson commented 4 years ago

Got it. I’ll be more explicit in the future!